FGT SW Review: General Comments

From Justin:

Finally some general thoughts/questions:

-Not sure where else to ask this, but does any of the logic in cluster/hit finding simplify if you were to create a StFgtStripCollection for both R and Phi?  It seems to me there are some places where you might benefit from being able to loop over only one plane at a time (this is what is done for the shower max planes in the EMCs), but its basically just a choice yosu have to make and then live with.

 

--->we decided against the split in r and phi planes.

-Where do you plan to associate hits from R and Phi in the code?  I guess you have a StFgtPointMaker which is not included in this review to combine StFgtHits?  Will this be reviewed separately or maybe I shouldn't worry about it.

--> there is a point maker which is not part of this review. How to combine hits is also still under investigation

 

-Comment on bfc.C, currently all the library loading etc. are hard coded into bfc.C, but presumably there will be chain options created for all these pieces and an "fgtDat" or something that can be loaded in the common chain.  It would be good to do this and compare the output with the currently hard-coded bfc.C

----> yes

-Where are muDst containers, do you want them for fastOffline analysis and QA, etc?  Only a fraction of the data has event.root trees saved, right Jerome?

 ---> the muDST maker part is not part of the review. We plan on copying over most of the data in the StEvent depending on event size restrictions