Home » Blogs » perev's blog

StiCA modifs

Updated on Mon, 2016-05-02 16:01. Originally created by perev on 2016-03-04 16:48.
  1.    Sti/Star/StiStarDetectorBuilder.cxx added line                                                                                                                                                        " if (! gGeoManager->GetVolume("FGTM")) return;"                                                                                                                                                   Probably reasonable.                                                                                                                                                                                                                            
  2. Sti/StiDetector.cxx modified  operator<<(ostream& os, const StiDetector& d)                                                                                                             
    Decreased amount of printing and print in degree instead of radians. Irrelevant;                                                                                                                                                                                                                                   
  3. StiMaker/StiDetectorVolume.h moved into
    Sti/StiDetectorVolume.h  NOT CLEAR WHY                                                                                                                                                               
  4. The same but line 107. Debug print only if volume is active. Not clear why but why not.                                                                                             
  5. Line 325 & 330 Print only if debug is on.      Reasonable                                                                                                                                                         
  6. Then a lot of double ==> Double_t and log ==> TMath::Log.   Senseless                                                                                                                     
  7.  Sti/StiElossCalculator.cxx   line 386                                                                                                                                                                    static Int_t iBreak = 0;
      if (TMath::IsNaN(dedx)) {
        iBreak++;}
      To check dedx for NaN is maybe reasonable. But only counting of such cases. I prefere assert here. If dedx is NaN then everything is wrong                   Senseless
  8. Again zillions of Double_t and TMath::                                                                                                                                                                          
  9.  Sti/StiHit.cxx line 243. assert removed. It is important assert. Wrong
     

                                                                                                                                                           

  10.   Sti/StiKalmanTrack.cxx Added method :getTpcSector() Search the first tpc hit and return its sector. It is not good adding in Sti direct dependency from StEven but it is CA. Accepted
  11.  

      Lines 1268-1287  debug lines oriented to Tpc & Svt NOT accepted   

  12.  Lines 1790-1797  Change is not clear. Removed test mag field !=0. field can not be zero, it could be small but not zero. If it is zero, something is wrong. Not accepted.    
  13. Line 1841. Replacement mass to PDG code. NOT Clear  why     
  14.                                                                                                                                                                                                                
»