Home » Blogs » qinz18's blog

Code QA for GPC # 390 L4HeProduction

Updated on Mon, 2025-08-11 23:41. Originally created by qinz18 on 2025-08-11 23:41.

 2025.8.12

- I have go through the code and run all of it following the README. The code is well-organized and works efficiently. The results match the expected outputs, and all figures were reproduced correctly—except for a small difference in Figure 5 (first data point), where the error value is slightly different, and Figure 2 seems only one rapidity bin, these need more check.

- Need check the filelock mechanism used in bash script(like runAna_rap*_SystErr_woTopo.sh), if you use it to parallel run, the filelock only protect the command of changing ` constPars.h`, The following root command itself is not lock-protected, especially the second root command after filelock may have the risk of `constPars.h` modified by other parallel scripts.
     Or mentioned it in README and recommend sequential execution of the bash scripts on different rapidity.

- Maybe Need output code in Step 4.3.3 and Step 4.4

- The Supplementary code `checkPID.C` need to be upload. 
 
»